Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management shell kills container too early #6

Open
TheJJ opened this issue May 4, 2016 · 2 comments
Open

Management shell kills container too early #6

TheJJ opened this issue May 4, 2016 · 2 comments
Labels

Comments

@TheJJ
Copy link
Member

TheJJ commented May 4, 2016

The management shell via ssh kills the container as soon as the ssh connection dies.
When restarting/powering off the VM, the ssh connection is closed before the machine is off.
-> The machine is killed before it is off.

I experienced data corruption as stuff was not yet synched to disk.

@TheJJ TheJJ added the bug label Jul 18, 2016
@TheJJ
Copy link
Member Author

TheJJ commented Apr 27, 2017

The solution is to add support in falk:
Kevin asks Falk "pls tell me when the VM is dead", then falk sends the reply when the machine went down. Kevin can then continue. (The whole thing is still timeout-wrapped so if the container doesn't go down, it's killed after x seconds).

@TheJJ
Copy link
Member Author

TheJJ commented Jul 15, 2017

I workarounded it by sleeping 5 seconds after the ssh is disconnected. The proper solution would be do implement async def wait_for_shutdown(timeout=60) for class FalkVM in kevin/falkvm.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant