Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoogleCharts] ChartEditor is not properly working in IRuby notebook #117

Open
Prakriti-nith opened this issue Aug 3, 2018 · 4 comments

Comments

@Prakriti-nith
Copy link
Contributor

In IRuby notebook charteditor dialog box appears behind the elements of the notebook like this:
image
Refer this comment.

@Shekharrajak
Copy link
Member

Refer #118 (comment)

@sayant1204
Copy link
Contributor

sayant1204 commented Feb 22, 2021

Hello @Shekharrajak,
I tried to solve this issue by using z-index. on clicking the edit button I am giving z-index to that container. Also, I gave some styling to the container.
js << "\n document.getElementsByClassName('modal-dialog')[0].style.zIndex = '2';" js << "\n document.getElementsByClassName('modal-dialog')[0].style.height = '60%';" js << "\n document.getElementsByClassName('modal-dialog')[0].style.width = '60%';" js << "\n document.getElementsByClassName('modal-dialog')[0].style.overflow = 'scroll';"

Does this approach look good?

Screenshot from 2021-02-22 23-59-35

@sayant1204
Copy link
Contributor

ping @Shekharrajak.

@Shekharrajak
Copy link
Member

Thanks @sayant1204 ! Can you please create a PR and send me the notebook link (with you example) ?

You can easily put the github link of the jupyter notebook here: https://nbviewer.jupyter.org/ and hopefully we can see it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants