Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Shutdown to aggro dialog and disable enter/return & escape keys #100

Open
wakco opened this issue Aug 14, 2024 · 2 comments

Comments

@wakco
Copy link

wakco commented Aug 14, 2024

I'd like to request a shutdown button on the aggro dialog, i.e. have the existing two buttons swap, so that Shut Down... and Restart... can sit next to each other.

In addition to this, I'd like to suggest the defaults for the Restart & (and requested) Shut Down buttons should match what appears in the Apple menu, i.e. Restart... and Shut Down..., this way it creates a more seemless connection between the button and what it does, for a consistent user interface.

@wakco
Copy link
Author

wakco commented Aug 14, 2024

Note for disabling keyboard actions with swiftDialog...

   --hidedefaultkeyboardaction 

	Hides the default behaviour of Return ↵ and Esc ⎋ keys

        When specified, the behaviour to action the default button (Return ↵) or secondary button (Esc ⎋) will be modified
        to require Command ⌘ + Shift ⇧ in order to action.

        This effectively disables unintentional activation of either of these buttons. They can still be activated
        with the keyboard, but it is harder to do so without intent.

@BigMacAdmin
Copy link
Collaborator

I think these are both good ideas, however at this time I don't think I'll be able to implement them.

The idea to have the primary button change to Shut Down is good, and something I wish had come to mind earlier in development. At this time, changing that button behavior would require breaking changes for users since I've included things like NoDeferralsRemainingButtonText and have the documented behavior that this button will be greyed out in aggro mode.

I will keep this open as a "maybe in v.2.0 if I decide to overhaul and introduce breaking changes."

As far as the option for default keyboard action, this can already be configured by the administrator by adding it to AdditionalDialogOptions and so my general stance on these is "leave it off by default, and users can add it if they want" because I don't want to have to think through and manage these things whenever Bart adds new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants