Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel cannot handle more than 12 places #52

Open
aforloney opened this issue Jan 14, 2015 · 9 comments
Open

Wheel cannot handle more than 12 places #52

aforloney opened this issue Jan 14, 2015 · 9 comments
Labels

Comments

@aforloney
Copy link

While increasing the number of places to display through the gear icon to more than 12, the display of the wheel does not update accordingly. This may require the Radius value to be increased to see the issue.

The issue becomes more noticeable as the number of places reach an unrealistic amount (ie, 100). A suggested fix would be to cap the number of results to a particular number or adjust the code to handle more than 12 places.

If need be, I can research and provide a suggested fix -- this issue was noticed during a cursory review,

@UsainBloot
Copy link
Owner

Please feel free to suggest a fix.

The # of Places displayed through the gear icon has an attribute to limit it to 12, but that can easily be overridden by typing.

I can see a potential issue with the text formatting strangely when the segments get smaller and smaller to accommodate more results.

@UsainBloot UsainBloot added the bug label Jan 15, 2015
@aforloney
Copy link
Author

One of the possible routes to fix this bug would be to alter the roulette wheel into a 'price of right wheel
where the UI does not need to worry about dividing the circle into N pieces from a side view. Rather, the wheel can be displayed from the front (similar to 'Price Is Right') so the amount of pieces is negligible However, that appears to be more of an enhancement than classified as a bug,.

@jbum
Copy link

jbum commented Mar 11, 2015

Text formatting is definitely an issue for getting more than 12. I was able to get 24 wedges at wheelof.com by writing the text sideways (so that the wedge at 3-o-clock is readable, versus the wedge at 12-o-clock). Using that format, you can fit up to about 32 wedges comfortably, although I capped it at 24 to make it more readable. I also play around with font-size so that shorter names use larger fonts.

@jbum
Copy link

jbum commented Mar 11, 2015

Attached is a rendering of an HTML5 version of the wheel at wheelof.com (the original was rendered in Flash, as you know).
screen shot 2015-03-11 at 12 06 27 pm
I can provide the code that renders it, if you're interested.

@aforloney
Copy link
Author

@jbum Thanks for updating.

I was thinking the wheel may be more extensible with the wheel rendering similar to the Wheel of Fortunate spinner. This would eliminate any sort of unintended side-effect where the names of the locations are squished onto the wheel to accommodate a higher value for number of locations.

After cloning the repository, I ran into problems trying to launch a local testing environment to test my changes so I have been delayed with suggestive code.

@UsainBloot
Copy link
Owner

@aforloney, what issues did you face when setting up locally, I can give you a hand if needed.

@aforloney
Copy link
Author

@UsainBloot While running locally, I was unable to complete the curl request for the list of places as it would just hang indefinitely. It may be an issue with cURL on my Windows machine but I didn't dive too deep into troubleshooting.

@UsainBloot
Copy link
Owner

@aforloney This is due to curl request only allowing access from certain domains or IPs. You can set up your own Google Places API account for testing purposes for free.
https://developers.google.com/places/documentation/

@aforloney
Copy link
Author

@UsainBloot Thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants