Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from react-fullscreenable to react-full-screen package #277

Open
stv0g opened this issue Oct 20, 2021 · 1 comment
Open

Switch from react-fullscreenable to react-full-screen package #277

stv0g opened this issue Oct 20, 2021 · 1 comment

Comments

@stv0g
Copy link
Contributor

stv0g commented Oct 20, 2021

In GitLab by @skolen on Oct 20, 2021, 11:00

For the full screen mode in the dashboards we should change from the react-fullscreenable package which is not longer maintained to the react-full-screen package for support of React 17. Currently we have a dependency problem because we are using React 17 and react-fullscreenable requires a peer of React 15 or React 16.

Related to #341

@stv0g
Copy link
Contributor Author

stv0g commented Oct 20, 2021

In GitLab by @skolen on Oct 20, 2021, 12:16

This problem is related to the security vulnerabilites that are mentioned in #341. React is "only" a dev dependency of react-fullscreenable so this problem is not critical to be solved. We should keep it in mind anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant