-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear out and remove /tests
directory
#1433
Comments
SGTM. For the images, we may want to shrink them down to speed up the tests as well. |
Otherwise, the only reason for a |
Makes sense to me. Regarding a combination of plugins, if we want to test that, I think the |
After #1262, there are still some files in the root
/tests
directory, which IMO seem a bit misplaced there. Mostly, the existence of the directory could lead to confusion for where tests should be added.Some thoughts:
tests/data
directories of the specific plugins that use them. If multiple plugins use these images, no harm to duplicate them across those locations. I think it makes sense for every plugin to self-contain its test data./plugins/optimization-detective/tests
.boostrap.php
file could be moved to our/tools
somewhere? Maybe a new directory/tools/phpunit
? It's a configuration helper for PHPUnit, similar to how there's already configuration helpers for e.g. PHPCS and PHPStan in that directory.cc @westonruter @thelovekesh
The text was updated successfully, but these errors were encountered: