Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to mock IRealtimeClient due to incorrect type defined in interface #1293

Open
StephenSmithBSC opened this issue Dec 12, 2024 · 0 comments
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@StephenSmithBSC
Copy link

StephenSmithBSC commented Dec 12, 2024

IRealtimeClient has a property "Channels" of type "RealtimeChannels" which is not an interface and has no public constructor. However, this class implements IChannels<IRealtimeChannel>. This implies that in IRealtimeClient.cs, the RealtimeChannels type should instead be IChannels<IRealtimeChannel>.

instead of this:

        /// <summary>The collection of channels instanced, indexed by channel name.</summary>
        RealtimeChannels Channels { get; }

it should be this:

        /// <summary>The collection of channels instanced, indexed by channel name.</summary>
        IChannels<IRealtimeChannel> Channels { get; }

┆Issue is synchronized with this Jira Task by Unito

@ttypic ttypic added the code-quality Affects the developer experience when working in our codebase. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

2 participants