Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enforce request structure during deserde #1872

Closed
mattsse opened this issue Dec 31, 2024 · 2 comments
Closed

[Feature] Enforce request structure during deserde #1872

mattsse opened this issue Dec 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Dec 31, 2024

Component

consensus, eips, genesis

Describe the feature you would like

executionRequests: Array of DATA - List of execution layer triggered requests. Each list element is a requests byte array as defined by EIP-7685. The first byte of each element is the request_type and the remaining bytes are the request_data. Elements of the list MUST be ordered by request_type in ascending order. Elements with empty request_data MUST be excluded from the list.

we currently don't enforce:

  • ordering
  • length

#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct Requests(Vec<Bytes>);

ordering could either be enforced in deserde or in request_hash #1871

if we do it in deserde then the consumer must ensure the requests are pushed in order

https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#engine_newpayloadv4

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Dec 31, 2024
@nadtech-hub
Copy link
Contributor

@mattsse
Copy link
Member Author

mattsse commented Jan 31, 2025

we now have the proper checks in place so we no longer need this

@mattsse mattsse closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants