Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation of the right version of Node #5633

Open
2 tasks
romaricpascal opened this issue Jan 20, 2025 · 0 comments
Open
2 tasks

Improve installation of the right version of Node #5633

romaricpascal opened this issue Jan 20, 2025 · 0 comments

Comments

@romaricpascal
Copy link
Member

What

Improve how we co-ordinate the version of Node that's needed to run the project across both our machines and CI. In a perfect world:

  • There'd be a single source of truth (package.json?)
  • A package update that needs a newer version would make CI fail (rather than pass at the moment because we install the latest 22)
  • Developers with a lower minor version than needed would be required to update on their machine
  • The process would work both with nvm and asdf

Why

We're using a .nvmrc file with only 22. Seems we need at least 22.12 due to some ESM packages being required. The latests minor version of Node 22 will be installed on CI, so things will work fine. However, on people's machine they may already have Node 22.11 installed, which satisfies the 22 in .nvmrc.

On top of that, we track the minimum Node version in the engines field of our repository's package.json (along with some of the packages in the repository as well, I think). It'd be great to

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've investigated what different configurations of .nvmrc and package.json allow in regards to the criteria in the decription
  • We're picked and implemented the best option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant