Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename messages parameter of govukI18nAttributes #5651

Open
1 task
romaricpascal opened this issue Jan 24, 2025 · 0 comments
Open
1 task

Rename messages parameter of govukI18nAttributes #5651

romaricpascal opened this issue Jan 24, 2025 · 0 comments

Comments

@romaricpascal
Copy link
Member

What

Rename the messages option of govukI18nAttributes, used to pass the different plural forms of a message.

The new name should be distinct enough from the option used when there's no plural form (message). A proposal would be messagePluralForms.

Why

It's current name is too close to message used when there's no plural forms, making it easy to make mistakes.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • The option name has been changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant