Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IntegerNullable Logical Type and have 1 Integer Logical Type #1516

Open
gsheni opened this issue Sep 7, 2022 · 2 comments
Open

Remove IntegerNullable Logical Type and have 1 Integer Logical Type #1516

gsheni opened this issue Sep 7, 2022 · 2 comments

Comments

@gsheni
Copy link
Contributor

gsheni commented Sep 7, 2022

  • We originally had IntegerNullable and Integer because EvalML relies on estimator/classifiers that do not support the pandas Int64 dtype (which is used in IntegerNullable)
  • However, a better long term solution is for Woodwork to have 1 Integer type that supports nullable values
  • For this issue
  1. Remove/Deprecate IntegerNullable
  2. Change the Integer physical type from int64 to Int64
  3. Update inference logic to account for this change
  4. Verify that Featuretools and EvalML can properly handle this change
@gsheni gsheni changed the title Remove IntegerNullable Logical Type and have 1 Integer Logical Type (that supports nullable values) Remove IntegerNullable Logical Type and have 1 Integer Logical Type Sep 7, 2022
@thehomebrewnerd
Copy link
Contributor

@gsheni Also Age and AgeNullable? Or maybe that should be separate since we also have AgeFractional that could/should be cleaned up?

@gsheni
Copy link
Contributor Author

gsheni commented Sep 8, 2022

@thehomebrewnerd yep, created: #1519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants