Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(compat, shared) missing enums transpilation from js-module-v1 #274

Open
ToffyMTA opened this issue Jan 10, 2025 · 5 comments
Open

(compat, shared) missing enums transpilation from js-module-v1 #274

ToffyMTA opened this issue Jan 10, 2025 · 5 comments

Comments

@ToffyMTA
Copy link
Contributor

enums transpilation in v1 was implemented here:
altmp/altv-js-module#319

@ToffyMTA
Copy link
Contributor Author

I just realized there was issue created in past about it but xLuxy closed it as not planned, so what's the point of compatibility mode if it's not really compatible (and not planned to be)?

#236

@xxshady
Copy link
Collaborator

xxshady commented Jan 10, 2025

ignore xluxy, it needs to be added

@xLuxy
Copy link
Contributor

xLuxy commented Jan 17, 2025

ignore xluxy, it needs to be added

You might want to ensure that the branch from which the types are being downloaded is correct. The only reason I kept the master branch was because the Code Editor (qa-tools) relied on the older altv-types branch logic before it was split into separate branches. Additionally, consider the potential consequences if any of the modules fail to load due to network connectivity issues or other unexpected problems causing enums to not be present. One of the main reasons why i never really liked the idea.

@xxshady
Copy link
Collaborator

xxshady commented Jan 17, 2025

if any of the modules fail to load due to network connectivity issues or other unexpected problems

I think github CI is always connected to internet? enums in jsv1 are transpiled on build step, not in runtime

@xxshady
Copy link
Collaborator

xxshady commented Jan 17, 2025

and also i'm not sure whether we should add same transpilation as in jsv1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants