You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When i rotate my log, i send a SIGHUP signal to inform my daemon so i can $logger->close() and force Monolog to free and reopen all handlers.
But the class Amp\Log\StreamHandler miss the close() method, the write method does not check the validity of the stream before writting, and StreamHandler cannot close and reopen a stream.
Workaround: i remove the StreamHandler from handlers and make a new one.
But the stream is not closed (lsof show my old log is still opened by php)
But i think a simple close() method is needed to close() the stream like it's done in Monolog\Handler\StreamHandler
and documented in Monolog\Handler\HandlerInterface.
The text was updated successfully, but these errors were encountered:
Hi,
When i rotate my log, i send a SIGHUP signal to inform my daemon so i can $logger->close() and force Monolog to free and reopen all handlers.
But the class Amp\Log\StreamHandler miss the close() method, the write method does not check the validity of the stream before writting, and StreamHandler cannot close and reopen a stream.
Workaround: i remove the StreamHandler from handlers and make a new one.
But the stream is not closed (lsof show my old log is still opened by php)
But i think a simple close() method is needed to close() the stream like it's done in Monolog\Handler\StreamHandler
and documented in Monolog\Handler\HandlerInterface.
The text was updated successfully, but these errors were encountered: