Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify testing assert style #959

Open
trim21 opened this issue Jul 4, 2024 · 4 comments
Open

unify testing assert style #959

trim21 opened this issue Jul 4, 2024 · 4 comments

Comments

@trim21
Copy link

trim21 commented Jul 4, 2024

there are many testing assert style in this project. for example,"github.com/stretchr/testify/assert", "github.com/stretchr/testify/require", github.com/frankban/quicktest and bare compare.

Are you open to unify these testing asserts to github.com/stretchr/testify/require only?

@anacrolix
Copy link
Owner

I actually want to unify them to frankban/quicktest, it's much better. The older tests use testify.

@anacrolix
Copy link
Owner

There's this now, which is even better https://github.com/go-quicktest/qt.

@anacrolix
Copy link
Owner

I had a crack at using gofmt and sed to move over to https://github.com/go-quicktest/qt but it wasn't trivial. The require and assert APIs should be easy to port over but the qt package alias collides with existing use of github.com/frankban/quicktest so that's hard too. Easier just to upgrade as needed.

@anacrolix
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants