Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that direct deploys require a glob-compatible path parameter #297

Open
filmaj opened this issue Dec 12, 2020 · 2 comments
Open

Clarify that direct deploys require a glob-compatible path parameter #297

filmaj opened this issue Dec 12, 2020 · 2 comments

Comments

@filmaj
Copy link
Member

filmaj commented Dec 12, 2020

Describe the issue
The current CLI reference for deploy makes no mention of the need to pass a path-like parameter to the command. Kind of integral to direct/dirty deploys!

Steps to reproduce
See https://arc.codes/reference/cli/deploy

Expected behavior
We should make that clear.

Additional context
Someone was having trouble with that command on Slack and this issue was a point of confusion! See https://architecture-as-text.slack.com/archives/C6BGT0D08/p1607807121269300

@tbeseda
Copy link
Member

tbeseda commented Sep 27, 2021

Looking at some open issues. This is an easy change that is still relevant IMO
But I'm wondering if we should remove "dirty" from the docs in favor of "direct". From what I can tell, "dirty" is legacy and just supported in architect/deploy as an alias for "direct" right?

@filmaj
Copy link
Member Author

filmaj commented Oct 16, 2021

I believe direct is preferred over dirty, though it has never been discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants