Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-single opens many new buffers when using line numbers #54

Open
gcentauri opened this issue Feb 28, 2020 · 2 comments
Open

verify-single opens many new buffers when using line numbers #54

gcentauri opened this issue Feb 28, 2020 · 2 comments

Comments

@gcentauri
Copy link
Collaborator

due to the buffer naming scheme in the code, we get many open buffers when using verify-single and line numbers. this is mostly harmless, but i'm not sure its expected behavior. if i remember correctly, other test runners replace the current test comint buffer rather than making a new one.

image

@xinyifly
Copy link

xinyifly commented Feb 4, 2025

I belive it's related to

(defun minitest--verify-single-rails ()
  ;; ...
  (minitest-run-file (format "%s:%s" file-name line-number))

and

(defun minitest-buffer-name (file-or-dir)
  (concat "*Minitest " file-or-dir "*"))

Maybe we should provide a custom variable named like minitest-buffer-name-reuse-file that removes the trailing : in file-or-dir

@gcentauri
Copy link
Collaborator Author

@xinyifly - thanks for the comment! i think you're right. I haven't made time for Emacs work lately but I like your suggestion. My initial hesitation was breaking behavior people were used to. Having an option to re-use the buffer name for verify single would be a good compromise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants