Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): enable support for executing tests if docker files are present #49

Open
dmccaffery opened this issue Mar 22, 2017 · 1 comment

Comments

@dmccaffery
Copy link
Member

dmccaffery commented Mar 22, 2017

Condo should support execution of E2E tests via detection of docker-compose.test.yml within the .docker folder. It should include the following docker-compose files in the execution, if present:

docker-compose.yaml
docker-compose.test.yaml
docker-compose.override.yaml

If any of the above are present and docker is already available on the build agent, then condo should build and run the containers without intervention.

Potential issues:

  • Timeout if the container(s) fail to exit?
  • Always set the --abort-on-exit flag for docker-compose
@dmccaffery dmccaffery self-assigned this Mar 22, 2017
@dmccaffery dmccaffery added this to the vnext milestone May 30, 2017
@sjk07
Copy link
Member

sjk07 commented Jun 7, 2018

additional information from #184 by @jellyDean
Currently E2E test are not integrated into condo or VSTS. When engineers need to submit PRs all of the tests (including E2Es) must pass. Because the E2E tests are not ran it causes many issues. Currently members of the superfine team are required to take a screen shot of the E2E tests passing in VS CODE locally and paste it to the PR they working on. The goal of this task is to remove screenshooting and integrate E2E tests into condo and VSTS. The overall goal is broken into two parts. The first getting E2E tests running in condo and the second getting them running in VSTS. After getting the tests running in condo getting them in VSTS shouldn't be so bad.

Goals

E2E tests passing without docker. Running condo.sh with all required dependencies running locally
E2E tests passing with docker. Running condo.sh with all required dependencies in their own containers
Integrating docker with condo. Condo spins up the necessary testing environment with all the required dependencies connected. Similar to VS Code task.
Run condo and it spins up necessary testing environment and runs all tests including E2Es. Testing environment is destroyed upon test completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants