Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Host header to build urls #951

Open
srstsavage opened this issue Sep 15, 2021 · 3 comments
Open

Use Host header to build urls #951

srstsavage opened this issue Sep 15, 2021 · 3 comments

Comments

@srstsavage
Copy link

Currently urls are built using localhost unless --api-host is explicitly passed. It would be nice if franklin inspected the Host header of incoming requests and used the value (if present) as the domain in the constructed url. This would allow a single franklin instance to be hosted under multiple domain names, among other deployment scenarios.

@srstsavage
Copy link
Author

Checking X-Forwarded-Host would be prudent as well

@jisantuc
Copy link
Contributor

Hey @shane-axiom, thanks for the issues! Just a heads up I probably won't be able to get to these until at least two weeks from now since close to 100% of my extra time right now is going toward preparing for a FOSS4G workshop I'm giving. Do you know Scala? If so I'd be happy to a review a PR that makes this change. Also feel free to drop by the Gitter channel if you run into any trouble

@srstsavage
Copy link
Author

No worries, I'm not blocked on these particular issues, they're more nice-to-have/best practices kind of requests. Appreciate the response and the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants