Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] automatic sync of new snapshots outside of the schedule #1235

Open
PrivatePuffin opened this issue Apr 27, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@PrivatePuffin
Copy link

Describe the feature you'd like to have.
Currently volsync snapshots the PVC and then copies/syncs those snapshots.
It would be great to have a solution to automatically, for example by regex, detect snapshots with a certain naming scheme and copy/sync those.

What is the value to the end user? (why is it a priority?)
This will create improved compatibility with tools/solutions that manage their own snapshots as well snapscheduler

How will we know we have a good solution? (acceptance criteria)

Additional context

@PrivatePuffin PrivatePuffin added the enhancement New feature or request label Apr 27, 2024
@tesshuflower
Copy link
Contributor

Thanks @Ornias1993 for your ER - I think this is something that sounds like a good idea, but not sure we're prepared to make this sort of change at the moment.

There are issues around scheduling, deciding which snapshots to use etc, which to pick and how to know if we've already synced a specific snapshot in the past. It would be easy to sync an older one by accident.

Is your use-case because you're doing some sort of quiescing before taking the snapshots? One thing you could look at is pvc annotations (copy triggers) if you need some more control over when the snapshot occurs. See the docs here: https://volsync.readthedocs.io/en/v0.9.1/usage/pvccopytriggers.html

@PrivatePuffin
Copy link
Author

Thanks @Ornias1993 for your ER - I think this is something that sounds like a good idea, but not sure we're prepared to make this sort of change at the moment.

There are issues around scheduling, deciding which snapshots to use etc, which to pick and how to know if we've already synced a specific snapshot in the past. It would be easy to sync an older one by accident.

Is your use-case because you're doing some sort of quiescing before taking the snapshots? One thing you could look at is pvc annotations (copy triggers) if you need some more control over when the snapshot occurs. See the docs here: https://volsync.readthedocs.io/en/v0.9.1/usage/pvccopytriggers.html

Tools that spawn their own PVC/statefullsets and manage their own snapshots of them, such as CNPG, now are completely incompatible with volsync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants