Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingameshop #18

Open
FunkyMMO opened this issue Jan 19, 2025 · 5 comments
Open

Ingameshop #18

FunkyMMO opened this issue Jan 19, 2025 · 5 comments

Comments

@FunkyMMO
Copy link

FunkyMMO commented Jan 19, 2025

Description

In ingameshop.properties I have:
gameserver.ingameshop.enable = true
and i use the -ingameshop launcher parameter. Even so the in-game store does not work.

@neon-dev
Copy link
Member

The ingame shop was removed from the game client with some earlier version.
There are files to patch it back in, but we have never tried them.
If you want to test it, please report back on compatibility with the 4.8 client. If the game client doesn't work well with it, we should remove support for it from the server as well.

@FunkyMMO
Copy link
Author

The ingame shop was removed from the game client with some earlier version. There are files to patch it back in, but we have never tried them. If you want to test it, please report back on compatibility with the 4.8 client. If the game client doesn't work well with it, we should remove support for it from the server as well.

Apparently that link is down. I'm going to see if I can get that pak from another client.

@FunkyMMO
Copy link
Author

FunkyMMO commented Jan 20, 2025

I got the following pack and put it inside ENG/Data/ but it doesn't seem to work
https://github.com/GiGatR00n/Aion-Core-v4.7.5/tree/master/AC-Tools/AC-Ingameshop

@neon-dev
Copy link
Member

I played around with it too, but couldn't get it to work either.
Comparing the ui_game.xml in ingameshop.pak with the one in the 4.8 client, I noticed many unrelated differences, as it was created for a much older client version. For best compatibility, I identified the ingame shop related changes (basically just the <Dialog /> with name="ingame_shop_dialog") and created a new patch file using the 4.8 UI as a base: ingameshop_4.8_test.zip
I could verify that the file was loaded correctly, but unfortunately it didn't help to get the shop button to appear.
I think the -ingameshop start parameter may have been removed, or maybe even the underlying ingame shop system. My few attempts to force the button to show did not work.

@neon-dev
Copy link
Member

neon-dev commented Feb 1, 2025

I have noticed that all *.pak patches containing the ui_game.xml or ui_game_override.xml files break some UI functions, such as opening the map. Even creating a dummy patch *.pak with unmodified XML files causes the same problem.
Someone with client modding experience would be needed to help with this before we can see if and how the ingame shop can be reactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants