-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂️ Road to Biome v2.0 #3727
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
I removed the task to rethinking formatter defaults. While I understand the motivation, there's no need. There's the option, so discussing defaults is just... bike-shedding. |
Why @ematipico is it back-shedding? Personally, each time I'm trying to replace eslint / prettier by Biome, there is a bunch of settings I need to set (the main one being to use spaces instead of tabs). If the defaults were different, I would not need to do this? |
@lcswillems I don't want to spur a discussion from here, so if you have some options, please create one. To answer your question, it's essentially impossible to have perfect defaults because people have opinions that differ from one to another. It all comes down to "De gustibus", where every opinion is legit but not a correct one. So, instead of focusing our (the team's and yours, the user's) energies on discussing which default "is correct", we should discuss the presence of options which are more productive for all parties. If defaults are different, they would help your, but they might affect other users. We can make the on-boarding easier, but there's always a party that might be discontent, which ties up to the beginning of the discussion. |
Hey @ematipico, thanks for your answer! It is indeed not possible to find a default that is optimal for each and every user. But it doesn't mean that there is not a default that is better than another overall, while considering the group of users. If the defaults in Biome were chosen randomly, it would be a nightmare to use Biome. Same thing for all the tools that we use in our daily life. The reason I took my personal example was just because I believe that all the people migrating from eslint / prettier would be in my situation (and so maybe a lot of users). And so I felt it was important to keep in mind. At the end of the day, I can understand that it might be low priority and not worth prioritizing for v2.0 or any release. But I don't think we should conclude that caring about the defaults is not important and that all the defaults are equivalent. |
And that's why |
Tasks
We will use this issue to track all the necessary breaking changes and removal of deprecation we plan to do for the next major of Biome.
Biome related
rome.json
#4243rome-ignore
#4251trailingComma
option #4256--apply
CLI option #4267BIOME_LOG_DIR
#4288BREAKING: Remove the deprecated support ofroot_path
from the LSP @nhedgerindentSize
option #4269{a,b}
glob pattern syntax for includes/excludes #2986.editorconfig
support by default #4812style
tocomplexity
. #4776biome <command>
should behave identically tobiome <command> ./
#3946JsParserSettings
for better override behavior #3297.js
and.ts
files #4385.js
and.ts
files #4716RegExep("", "")
) support in regex-related rules (noControlCharacterInRegex
andnoMisleadingCharacterClass
)-
noMultipleSpacesInRegularExpressionLiterals
->noMultipleSpacesInRegex
-
noUnusedTemplateLiteral
->noUselessTemplateLiteral
?Think about adopting the same defaults as Prettier for our options to make migration easier. Notably,indentStyle
.requireAscii
by default #1918vcs.useIgnoreFile
ignores nested ignore files #2312📎include
should prevent Biome of traversing non-included directories #2000package.json
like Prettier does, by default #4370skipped_diagnostics
->skippedDiagnostics
#4366BREAKING
assert {}
#4359biome_rowan
methods #4296WorkspaceError
#4668biome.json
andbiome.jsonc
are located in the same folder #4936--config-path
andBIOME_CONFIG_PATH
. We should handle only.json
and.jsonc
and emit an error otherwise. #4942organizeImports
a full-fledged assist actionmax_line_length
from editorconfig #4892Infrastructure and community related
These tasks are for the great Biome community and infrastrcture.
knope
for automated release processchat.biomejs.dev
sub-domain, create a redirect to the discord invite link, and change all the occurrences to usechat.biomejs.dev
Developments
next
branch, and regularly rebasemain
intonext
until we reach a point where we can mergenext
intomain
.main
intonext
. Please DOT NOT USEgit merge
. Please usegit rebase
git rerere
for your sanity. This feature will cache all the conflict resolutions on your local machine, so next time you happen to have the same resolution, git will apply it automatically. Very useful when rebasing the same branch.Engagements with this issue
If possible, please refrain from commenting on this issue unless you're involved with the developments. If you want to discuss a decision, please use the relative issue. If an issue doesn't exist, please use Discord, or wait for an issue to be open.
The text was updated successfully, but these errors were encountered: