Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

podium crashes on php 5.4 #113

Open
eLFuvo opened this issue May 25, 2017 · 2 comments
Open

podium crashes on php 5.4 #113

eLFuvo opened this issue May 25, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@eLFuvo
Copy link

eLFuvo commented May 25, 2017

I.m using now 5.4.45 version of PHP.
After install I had seen the following error:

PHP Compile Error – yii\base\ErrorException

Can't use function return value in write context

...
/vendor/bizley/podium/src/models/db/ThreadActiveRecord.php:147

public function requiredPollAnswers()
    {
        if ($this->pollAdded) {
            $this->pollAnswers = array_unique($this->pollAnswers);
            $filtered = [];
            foreach ($this->pollAnswers as $answer) {
->                if (!empty(trim($answer))) {
   

Same error in /vendor/bizley/podium/src/models/db/PollActiveRecord.php:89

Please fix it.

Thanks for you greate work!

@bizley bizley self-assigned this May 25, 2017
@bizley bizley added the bug label May 25, 2017
@bizley bizley added this to the 0.8 milestone May 25, 2017
@tomaszkane
Copy link
Contributor

BTW, Yii2 works on 5.4, but this PHP version is end of life now.
http://php.net/supported-versions.php so IMHO is not a crime to ignore it :-)

@bizley
Copy link
Owner

bizley commented May 26, 2017

Yes, but unfortunately as long as Yii 2.0.* supports this I must as well. With 2.1.* we are back to sanity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants