About submitting some of the above questions in 453fc63.

[Uiugkhbkhbkg]

@JingMatrix Hi! I noticed some of your implementations in this submission, and I appreciate your efforts. However, I did come across a potential issue. Specifically, I'm concerned about how system applications with root permissions are handled. It seems like these applications are being treated as untrusted_app in the submitted code, but I think there should be additional logic to handle this case.

My concern is that if the default SELinux context is shown as untrusted_app, some less experienced users might mistakenly think the root permission hasn't been granted correctly. I'd love to hear your thoughts on this approach.

[JingMatrix]

I didn't understand your concern. Please provide examples to justify your ideas.

[Uiugkhbkhbkg]

Thanks for your reply! Let me explain my concern with some examples:

1. System Applications with Root Permissions
   Consider a scenario where a system application (e.g., a pre-installed system utility) is granted root access. In your current implementation, it seems that such applications are displayed with the untrusted_app SELinux context. However, this may not accurately reflect their privileged status and could lead users to believe the application hasn’t been granted root permissions correctly.

2. User Confusion and Misinterpretation
   If an application is successfully granted root permissions but still displayed as untrusted_app, ordinary users might get confused and assume the permissions are not functioning as expected. This could cause unnecessary issues during user operations or when deciding on permissions.

In summary, my main concern is that displaying all applications as untrusted_app, regardless of their actual permissions or system-level status, may not accurately represent their true state. This could result in user confusion or misjudgment about permission configurations.

Looking forward to hearing your thoughts on this!

[JingMatrix]

When an app is granted with root in APatch, its Selinux is not shown as untrusted_app.
By examples, I meant that showing us your CONFIG_FILE to justify that your ideas are coherent with reality.

[JingMatrix]

User reported to me that there is a delay/mistake of updating SELinux context label in UI.
Could you please confirm it? You can try reboot and see if the label changes in UI.

[Uiugkhbkhbkg]

I'll ask a friend of mine, who is using APatch. Is there any problem in this respect?

…

---Original--- From: ***@***.***> Date: Thu, Jan 23, 2025 00:03 AM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [bmax121/APatch] About submitting some of the above questions in453fc63. (Discussion #895) Uses reported to me that there is a delay/mistake of updating SELinux context label in UI. Could you please confirm it? You can try reboot and see if the label changes in UI. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

[JingMatrix]

The UI bug was fixed in f35f416, this discussion can be closed now.