Something terribly wrong with oik-shortcodes batch logic

[bobbingwide]

php_errorlog phpunit.json phpunit.xml.dist
bworguk@c17064 [~/public_html/wp-content/plugins/oik-shortcodes]# tail -f php_errorlog
[08-Feb-2019 15:57:54 UTC] PHP Warning: file(/home/bworguk/public_html/wp-content/plugins/woocommerce/.codeclimate.yml .eslintignore .eslintrc .scrutinizer.yml .stylelintrc .travis.yml CHANGELOG.txt Gruntfile.js assets/css/admin-rtl.css assets/css/admin.css assets/css/admin.scss assets/css/helper-rtl.css assets/css/helper.css assets/css/helper.scss assets/css/jquery-ui/images/ui-bg_flat_0_aaaaaa_40x100.png assets/css/jquery-ui/images/ui-bg_flat_75_ffffff_40x100.png assets/css/jquery-ui/images/ui-bg_glass_55_fbf9ee_1x400.png assets/css/jquery-ui/images/ui-bg_glass_75_e6e6e6_1x400.png assets/css/jquery-ui/images/ui-bg_glass_95_fef1ec_1x400.png assets/css/jquery-ui/images/ui-icons_222222_256x240.png assets/css/jquery-ui/images/ui-icons_2e83ff_256x240.png assets/css/jquery-ui/images/ui-icons_454545_256x240.png assets/css/jquery-ui/images/ui-icons_888888_256x240.png assets/css/jquery-ui/images/ui-icons_cd0a0a_256x240.png assets/css/photoswipe/default-skin/default-skin.svg assets/css/twenty-nineteen-rtl.css assets/css/twenty-nineteen.css assets/css/twent in /home/bworguk/public_html/wp-content/plugins/oik-shortcodes/classes/oik-listapis2.php on line 131
[08-Feb-2019 15:57:54 UTC] PHP Warning: Invalid argument supplied for foreach() in /home/bworguk/public_html/wp-content/plugins/oik-shortcodes/admin/oik-files.php on line 11
[08-Feb-2019 15:57:54 UTC] WordPress database error Column 'post_content' cannot be null for query INSERT INTO wp_7_posts (post_author, post_date, post_date_gmt, post_content, post_content_filtered, post_title, post_excerpt, post_status, post_type, comment_status, ping_status, post_password, post_name, to_ping, pinged, post_modified, post_modified_gmt, post_parent, menu_order, post_mime_type, guid) VALUES (0, '2019-02-08 15:57:54', '2019-02-08 15:57:54', NULL, '', 'Parsed: 68445', '', 'publish', 'oik_parsed_source', 'closed', 'closed', '', 'parsed-68445', '', '', '2019-02-08 15:57:54', '2019-02-08 15:57:54', 0, 0, '', '') made by oik_wp_loaded, oik_batch_run, oik_batch_run_script, do_action('run_oik-shortcodes.php'), WP_Hook->do_action, WP_Hook->apply_filters, oiksc_run_oik_shortcodes, oiksc_lazy_run_oik_shortcodes, _ca_doaplugin_local, oiksc_do_files, _ca_dofile_local, _lf_dofile_local, oiksc_local_oiksc_create_file, oiksc_display_oik_file, oiksc_parsed_source->update_parsed_source, bw_create_parsed_object, wp_insert_post
[08-Feb-2019 15:57:55 UTC] PHP Warning: file(/home/bworguk/public_html/wp-content/plugins/woocommerce/.codeclimate.yml .eslintignore .eslintrc .scrutinizer.yml .stylelintrc .travis.yml CHANGELOG.txt Gruntfile.js assets/css/admin-rtl.css assets/css/admin.css assets/css/admin.scss assets/css/helper-rtl.css assets/css/helper.css assets/css/helper.scss assets/css/jquery-ui/images/ui-bg_flat_0_aaaaaa_40x100.png assets/css/jquery-ui/images/ui-bg_flat_75_ffffff_40x100.png assets/css/jquery-ui/images/ui-bg_glass_55_fbf9ee_1x400.png assets/css/jquery-ui/images/ui-bg_glass_75_e6e6e6_1x400.png assets/css/jquery-ui/images/ui-bg_glass_95_fef1ec_1x400.png assets/css/jquery-ui/images/ui-icons_222222_256x240.png assets/css/jquery-ui/images/ui-icons_2e83ff_256x240.png assets/css/jquery-ui/images/ui-icons_454545_256x240.png assets/css/jquery-ui/images/ui-icons_888888_256x240.png assets/css/jquery-ui/images/ui-icons_cd0a0a_256x240.png assets/css/photoswipe/default-skin/default-skin.svg assets/css/twenty-nineteen-rtl.css assets/css/twenty-nineteen.css assets/css/twent in /home/bworguk/public_html/wp-content/plugins/oik-shortcodes/classes/oik-listapis2.php on line 131
[08-Feb-2019 15:57:55 UTC] PHP Warning: Invalid argument supplied for foreach() in /home/bworguk/public_html/wp-content/plugins/oik-shortcodes/admin/oik-create-apis.php on line 307

[bobbingwide]

It was a change to class Git - converting tabs, carriage returns and line feeds to blanks that broke the code. Quickfix appears to be to modify result_as_array() to take this into account.

[bobbingwide]

That fixed it!