Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion error (space before comma) for baseball players (in french) #8

Open
doplu opened this issue Jul 30, 2020 · 4 comments
Open
Labels

Comments

@doplu
Copy link

doplu commented Jul 30, 2020

Hello,
I noticed that the suggestion is always wrong for Baseball players :
"Insérez une espace après la virgule et non avant"
https://ibb.co/R7dPjw3
https://fr.wikipedia.org/wiki/Jorge%20Soler

Thanks in advance ;)

@bperel bperel added the backend label Jul 31, 2020
@bperel
Copy link
Owner

bperel commented Aug 1, 2020

I'm not sure how this false suggestion could be prevented : the syntax with the comma is specific to baseball, in all other cases the suggestion is correct ; and Wiper doesn't have a way to know that in this particular case the sentence is about baseball.

@doplu
Copy link
Author

doplu commented Aug 2, 2020

Ok Thanks. Does Wiper can exclude some article's categories (or does it just takes some random sentences and try to find an error)?

@bperel
Copy link
Owner

bperel commented Aug 11, 2020

Missed your comment, sorry about that.
Wiper currently doesn't care about the article's categories. The only thing that is filtered out is articles not belonging to the main namespace (so for instance discussion pages and user pages are ignored).

I'm not sure if it would be worth it to ignore articles based on their categories : once again, we face the issue of also ignoring potential real positives : if I have this sentence :
image
I would still want the 1st mistake to be found.

The ideal solution would be if there was a special markup in wiki to indicate these baseball points ; then wiper can easily detect if the text is within this markup and ignore it like it does for foreign-language texts.

@doplu
Copy link
Author

doplu commented Aug 12, 2020

Thanks for your explanations. ;)
In that case is excluding "{{Portail|baseball|Cuba}}" (taken from the wikipedia page code https://fr.wikipedia.org/wiki/Jorge_Soler?veaction=editsource) or just "{{Portail|baseball|}" would do the trick ?
I agree that it would alas miss real positive errors.
False positives could really be hard to solve with (automatic or) semi-automatic tools !
See you ;)
ps: see image https://ibb.co/GcdwnTV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants