Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmtime should always print guest panics #10122

Open
tschneidereit opened this issue Jan 27, 2025 · 1 comment
Open

Wasmtime should always print guest panics #10122

tschneidereit opened this issue Jan 27, 2025 · 1 comment
Labels
enhancement wasmtime Issues about wasmtime that don't fall into another label

Comments

@tschneidereit
Copy link
Member

Feature

Currently, Wasmtime doesn't always print anything to stderr when the guest panics: e.g. when serving incoming HTTP requests, panics are only printed if they happen before a response is sent. If the panic happens after the response headers have been sent, the panic is silently swallowed, and will only show up with the right WASMTIME_LOG incantation.

Benefit

Make guest panics easier to identify and debug.

Implementation

I'm not sure where this needs to be added, unfortunately.

Alternatives

Do nothing.

@tschneidereit tschneidereit added enhancement wasmtime Issues about wasmtime that don't fall into another label labels Jan 27, 2025
@alexcrichton
Copy link
Member

Do you have an example to run? Glancing at the logging in wasmtime serve it looks like it's writing everything to stdout/stderr as soon as it gets it, so I'm not immediately sure where the issue might lie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Development

No branches or pull requests

2 participants