Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for expo example in native libraries #725

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Dec 8, 2024

This doesn't work yet since Expo doesn't support react-native.config.js for linking the module. We need to figure out another option.

Edit: actually seems like it's because there's a bug in Expo's autolinking mechanism. PR here expo/expo#33532

@satya164 satya164 force-pushed the @satya164/expo-example branch from bc5f10b to aaba90f Compare December 8, 2024 22:06
@satya164 satya164 force-pushed the @satya164/expo-example branch 3 times, most recently from 9dd0909 to a063eb6 Compare December 9, 2024 12:31
@satya164 satya164 force-pushed the @satya164/expo-example branch from a063eb6 to 5d0ae8b Compare December 9, 2024 12:38
@KiwiKilian
Copy link

KiwiKilian commented Dec 30, 2024

Would this allow two parallel examples? React Native and Expo in parallel? While we use Builder Bob, we ditched the example. Instead we have monorepo setup to have a React Native and Expo example app in parallel, to validate both flavors work. https://github.com/maplibre/maplibre-react-native/tree/807db0e22593cc48fc316dcd9e91c27b1e6186a3/packages

We also included the plugin into the Builder Bob build, which might be interesting to others, who have to distribute a expo plugin to make their library work? See maplibre/maplibre-react-native#576.

@satya164
Copy link
Member Author

@KiwiKilian the CLI will only generate a single example of the chosen type, but you can always copy the example folder to a new folder to have 2 examples.

@KiwiKilian
Copy link

Only problem with this approach is the code sharing between both examples. But I do understand, that you won't to support this from the CLI creation, as it's rather complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants