-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour options / settings / preferences #20
Comments
A user wrote in 2013 (#73): "Hi Chris. I'm playing Keen and have run into a problem. I'm color blind. Do you think you could change the colors to not be green and red so that I can see when I've made a mistake?" |
Related feature request from Felipe Lessa: "night mode with a black background". Certainly possible, but each backend would need careful tweaking: currently they accept an arbitrary background colour but will typically give up and adjust the background if it doesn't contrast with both white and black. |
An inverse color mode would be good enough for my main use case, which is playing on the dark. Of course, a nice custom dark palette would be even better, but I have no idea how much development cost that entails :). |
Another colour blind user points out the inaccessibility of Map. There's actually an alternate colour set selectable at compile time but it doesn't look like it'd help; it's red, green, yelow, blue. A letter mode was also suggested; filed as #221. And a useful reminder: "If you decide to make changing the palette an option, keep in mind that different individuals have difficulty with different ranges of colour. For example, with the red/green/yellow/blue palette suggested on github, I would have trouble with the red/green distinction, but others would have trouble with the blue/yellow. Either having multiple palette options, or having each colour in the palette individually selectable, would probably be the easiest way to make the puzzle as accessible as possible without using the letter labels." |
Another request for night mode: "I really like solving one of your puzzles right before falling asleep. But, very often the screen just feels too bright for this to be healthy. Might it be possible to include a night mode in which most of the screen is black?" |
I'm not convinced by the colour inversion code; I'll need to provide a manually chosen list I think. Also the night help CSS needs link colours brightening.
This will help when writing a list of night colours, and when eventually making colours user-configurable.
I changed the Map colours in 160012b (improving colour blind accessibility and night mode compatibility) and have two unhappy users so far. David B. Hecht writes:
and Linda George asks in a Play review to
Edit: Avonlea Gardner and falcathief requested original colours by email as well. |
It would be an exaggeration to call me an unhappy user, but I do have a problem with this game: |
I would also enjoy the ability to customize all colours (i.e. even black + white) just for aesthetic reasons, if possible. Colourblind accessibility is the most important reason to make this change, but once it's in, hopefully it would be doable to not just stop at hard-coding alternate sets for the colourblind-problematic games, but having a section of the preferences to tweak all of it at will? |
Just to explicitly note it here: Simon has mentioned a plan to add colour preferences upstream, so I will wait for that to happen before adding anything on Android. |
Thank you for pointing that out :) ¹ i.e. Since this is more than one simple application, offering users the ability to create their own color palette may be a good idea. Suggestion This would also allow sharing themes easily |
I agree about customizable colors being the best solution. Being able to set each of the puzzle related colors and background is surely the most complete possible solution in terms of both accessibility and user preference, and should leave no room for anyone to complain about it if implemented. @chrisboyle do you know whether or not that's what Simon plans to add or if he might be thinking more like a couple hard-coded options? Not sure how much he divulged of his plan |
I'd like to see options to customize colors. Light yellow on light gray can be really hard to see on the line-based games.
The text was updated successfully, but these errors were encountered: