Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TagLab version update issues #161

Open
wogreene opened this issue Oct 29, 2024 · 6 comments
Open

New TagLab version update issues #161

wogreene opened this issue Oct 29, 2024 · 6 comments

Comments

@wogreene
Copy link

Hi all -

Great to see a new update come out! In attempting to upgrade, I've run into issues. Because it now requires Python 3.11, I've had to rebuild all dependencies (we were using python 3.9 previously). In the install script, it's seeming like it is mandating torch 1.13.1, but there are no wheels out there for that version of torch and python 3.11. For reference, I'm running CUDA 11.6 (what we found worked best with the previous release of TagLab), but I'm not sure that's the issue here. If you all could provide some guidance as to what we should do about torch version / python version incompatibility, along with which version of CUDA is preferred for the new release, that would be great. Thanks!

-Will

@Jordan-Pierce
Copy link
Contributor

I believe the updated install.py script has not yet been pushed from the devel branch to main.

@wogreene
Copy link
Author

wogreene commented Oct 29, 2024 via email

@maxcorsini
Copy link
Member

Hi all, it seems that for some reason the install.py is the old one. Now it should work. Run update.py and then install.py. Pay attention that now TagLab supports Python 3.11 only.

Max

@Jordan-Pierce
Copy link
Contributor

@wogreene ensure that when installing w/ 3.11 you specify the SAM flag:

python install.py SAM

As it's an optional addition, but currently needs it.

@massimomartinelli might I recommend making it part of the typical install? As even on a CPU, it still works, just slower. But right now without the SAM flag included, it doesn't get installed, but is still imported in SAM.py and Interactive_SAM.py., throwing an error. Submitting a PR right now on devel in case you want it.

Maybe in the far future there could be a dialog box somewhere to set the model so if someone wants to use vit_b, instead of vit_h?

@maxcorsini
Copy link
Member

Now SAM is an option because the vit_h is really demanding. What is wrong here is that if segment_everything is not installed the tools need to be removed from the toolbar to avoid issues. This is checked using importlib but perhaps there is some bug elsewhere, I will check ASAP.

@maxcorsini
Copy link
Member

For the moment, install.py force SAM installation, when the bug will be found we came back to the optional installation of SAM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants