Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: sql metrics not being captured properly #335

Open
daniel-codecov opened this issue Mar 18, 2024 · 1 comment
Open

bug: sql metrics not being captured properly #335

daniel-codecov opened this issue Mar 18, 2024 · 1 comment
Labels
bug Something isn't working Low Low Priority Issues (to be fixed or re-evaluated in 12 months Platform Platform

Comments

@daniel-codecov
Copy link
Contributor

daniel-codecov commented Mar 18, 2024 •
edited
Loading

The SQL metrics in worker currently don't track full-runtime, success and error at all because they fall out of the django commit in file:tasks/base.py.

Rework the context managers so that the db operations to capture those metrics actually get included in the django commit.

EG: full-runtime stopped getting captured sometime around March 7th 2024
@daniel-codecov daniel-codecov added the bug Something isn't working label Mar 18, 2024
@thomasrockhu-codecov thomasrockhu-codecov added wontfix This will not be worked on and removed wontfix This will not be worked on labels Oct 10, 2024
@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov to add Low and Platform labels

@thomasrockhu-codecov thomasrockhu-codecov added Low Low Priority Issues (to be fixed or re-evaluated in 12 months Platform Platform labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Low Low Priority Issues (to be fixed or re-evaluated in 12 months Platform Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrian-codecov @thomasrockhu-codecov @daniel-codecov