Upgrade to support ES 5.x

[lucid-0]

I will be working on updating a project that uses collective.elasticsearch to ES version 5+. We've noticed several breaking changes in the es query DSL / API since es 2.4.3 and wonder if there is interest in committing our changes/fixes here.

[fulv]

I have several changes I would like to contribute back to upgrade to ES 5+.

I see that there is a test-with-newer-es branch opened by @jensens, but it's mostly isort and travis improvements, no ES-specific fixes.

@jensens, should we keep going on your branch, or do you recommend starting over?

[jensens]

Do with it what you want :) or what fits best for you/ your use-case.

We (@agitator and I) decided to go a different path and created https://github.com/collective/collective.es.index
It is a different approach, its not yet perfect. But it works overall very fine on Plone 5.1 and ES 6.

[fulv]

Hmm, unfortunately, collective.es.index does not seem to work on Plone 4.

[vangheem]

I'm open to anyone else taking over maintenance.

[jensens]

@fulv no, it was developed for 5.1 only.

[tkimnguyen]

@jensens what's the difference in approach? Would be good to explain it in your README (or this repo's). @lucid-0 I think this repo is our baby now :)

[fulv]

@vangheem I'd be glad to take over maintenance since I'm deep in elasticsearch work and need to make a bunch of upgrades. Thanks for granting me the requisite permissions.

[vangheem]

What is your pypi username?

[fulv]

fulv

[vangheem]

@fulv added!

@tkimnguyen also added you, Joel and Sam!

[jensens]

what's the difference in approach?

It does not index on field base and try to mimic the catalog.
It indexes the whole json serialized content item (we utilize restapis serializers adapters and the in Plone 5.1 here).

The (optional) proxy index provided is a custom query on the ES, one use case is to use it as an drop-in index on SearchableText, but also as anything else and may query anything available.

OTOH, one may query the ES from some view directly and may have really fast listings possible.