Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get holidays by faith #367

Open
dmwelch opened this issue Oct 31, 2022 · 2 comments
Open

Get holidays by faith #367

dmwelch opened this issue Oct 31, 2022 · 2 comments

Comments

@dmwelch
Copy link

dmwelch commented Oct 31, 2022

Hi team,

I'd like to use this package to support my scout troop, which consists of Christians, Jews, and Hindus currently. In addition to our region, I'd also like to include the holidays for the faiths we represent so we can plan our annual program without excluding any group over another. How would that best be done?

Cheers,
Scoutmaster Dave

@commenthol
Copy link
Owner

Hi @dmwelch,
I'd recommend you to start your own calendar with date-holidays-parser.
Please take a look at https://github.com/commenthol/date-holidays-parser/blob/master/test/fixtures/custom.yaml and https://github.com/commenthol/date-holidays-parser/blob/master/test/Holidays.mocha.js#L18 on putting things together.
For conversion from yaml to json you might want to use the CLI of js-yaml.

@J-Hoh J-Hoh mentioned this issue Nov 4, 2022
@groenroos
Copy link

I'd also be interested in this! Writing and parsing my own calendar definition seems like loads of manual work to create and keep updated - and more importantly, since I don't personally have loads of in-depth familiarity with the different faiths, I wouldn't be able to know if the definition I created was accurate.

Since the data here already has some awareness of faiths (even if only in comment form), feels like it'd more useful to add faith metadata to the holiday definitions in this project.

This information can be increasingly relevant in some countries, e.g. US or GB, where significant portions of the multicultural population celebrate various faith-based holidays, even if they are not government-recognised holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants