Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedstock renaming request #1326

Open
jakirkham opened this issue Jan 18, 2025 · 1 comment
Open

Add feedstock renaming request #1326

jakirkham opened this issue Jan 18, 2025 · 1 comment

Comments

@jakirkham
Copy link
Member

Periodically feedstocks need to be renamed

In fact this was discussed very early on in conda-forge development ( conda-forge/conda-forge.github.io#179 ) as it was already spotted as a tricky case that we would like to smooth out (ideally with some automation)

There are a few cases where this happens...

  1. The upstream library was renamed
  2. It is later decided the name of the feedstock wasn't right (some examples below)
    2.a. It has a python-* prefix when upstream doesn't and there is no risk of confusion
    2.b. Its name overlaps with other related concepts/packages and needs qualification (like adding python- to build)
    2.c. The name is otherwise confusing, misleading, or otherwise muddies the waters

Here are a number of issues about renaming feedstocks

The current approach in these cases is to archive the feedstock and add a new recipe with the new name to staged-recipes. For some cases this may make some sense. That said, it does add a lot of complexity when renaming a feedstock. It also opens the door for additional requests on the person doing the rename that are well outside the scope of renaming the library. Not to mention there are many manual pieces that still need to be handled after. For example...

  1. Filing an issue to explain why the old feedstock is being sunset
  2. Migrating issues from the old feedstock to the new one
  3. Archiving the old feedstock
  4. Adding a linter hint to transition to the new name
  5. Adding a migrator to transition to the new name: Package transitions at conda-forge conda-forge.github.io#1894
  6. ?

Having so manual steps covered like this leads to idiosyncratic differences, missed steps, and confusion

A better approach would be to add a rename request workflow to this repo

As this repo already has the logic needed to convert recipes at staged-recipes, it should be possible to reuse this in the renaming workflow. We could also handle transferring open issues with the GitHub CLI and create an archive issue. Already we handle the archive workflow here so that could be reused ( and perhaps improved: #1324 ). We already are familiar with creating bot PRs to conda-forge-pinning. So we could use this to add a hint. It would also make sense to add a migrator

If there are other requirements I've missed, which only points out how much there is to do here, we could consider capturing those requirements in this workflow as well

If new requirements came up in the future, we would have a way to encode them in this request workflow and systemize them

@isuruf
Copy link
Member

isuruf commented Jan 18, 2025

We also need to update cirun permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants