Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress 14 performance degradation in certain circumstances on linux, in electron, in headless mode #30980

Open
ryanthemanuel opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels
type: performance 🏃‍♀️ Performance related v14.0.0 🐛 Issue present since 14.0.0

Comments

@ryanthemanuel
Copy link
Collaborator

Current behavior

There is a degradation in performance on linux, in electron in headless mode. This can be seen with this project. The performance seen is:

Spec Cypress 13.x Cypress 14.0
alert.cy.js 00:03 00:05
analysis.cy.js 00:23 00:53
aotf.cy.js 00:08 00:48
dashboard.cy.js 00:05 00:05
drawer.cy.js 00:03 00:03
editRuntimeForm.cy.js 00:09 00:25
gantt.cy.js 00:05 00:10
graph.cy.js 00:17 01:02
graphiql.cy.js 00:02 00:02
gscan.cy.js 00:10 00:33
header.cy.js 00:02 00:12
info.cy.js 00:01 00:01
layout.cy.js 00:01 00:01
log.cy.js 00:10 00:27
menu.cy.js 00:07 00:48
mutation.cy.js 00:10 00:51
table.cy.js 00:09 00:34
toolbar.cy.js 00:04 00:12
tree.cy.js 00:13 00:16
url.cy.js 00:01 00:01
userprofile.cy.js 00:08 00:27
workflowsTable.cy.js 00:02 00:05
workflowservice.cy.js 00:05 00:07
workspace.cy.js 00:08 00:38
All specs passed! 02:59 08:57

After some digging, it appears that this happens specifically when we upgrade to 28.0.0 in Electron (we upgraded to 33 as a part of 14 but specifically 28.0.0 seems problematic). Looking at the test replay of what is happening in these tests, it appears that at least one of the main culprits is a v-menu is taking 3 seconds to dismiss where it previously took .1 seconds.

Desired behavior

There should not be a performance degradation.

Test code to reproduce

This can be seen with this project.

Cypress Version

14 and above

Node version

v20.18.1

Operating System

Linux

Debug Logs

Other

No response

@ryanthemanuel
Copy link
Collaborator Author

For those following this issue, I investigated a bit and determined it was specifically an issue with animations (in this case closing a menu taking 2 seconds vs. .2 seconds), on Linux, headlessly, in Electron 28.0.0 and greater. I logged an issue to Electron to see what their thoughts are: electron/electron#45398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: performance 🏃‍♀️ Performance related v14.0.0 🐛 Issue present since 14.0.0
Projects
None yet
Development

No branches or pull requests

2 participants