Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigmoid: Increase the default target white slider maximum to 150% (or other value) #18271

Open
europlatus opened this issue Jan 23, 2025 · 3 comments

Comments

@europlatus
Copy link

Is your feature request related to a problem? Please describe.
The Sigmoid module's target white slider currently defaults to 0-100, and you need to type in higher values (or use keyboard shortcuts). Increasing the target white value is a useful way to create more contrast in the highlights. Some users find that Sigmoid compresses highlights too much, so the option to increase the white point should be more visible. I increase the slider quite regularly, and I've noticed Boris Hajdukovic does this too in his tutorial videos.

Describe the solution you'd like
Although the slider can still default to 100%, the max visible value could be something like 150% (or even 200%) to make it clearer to users that they can increase this value without the need to enter manual values.

@todd-prior
Copy link

todd-prior commented Jan 23, 2025

If you want to can just create a preset called slider boost....base it on sigmoid...set the slider to 200 then scroll back to 100 for the value and then save it as an auto preset if you want or use sigmoid all the time or just a regular one if you apply it ad hoc... if you do this when you compress with the sigmoid workflow it will be what you get as a starting point, also I think there is a key modifier that lets you scroll past the soft limit with the mouse... Just don't double click to reset to default that will reset the expanded limit...

@europlatus
Copy link
Author

I know there are those workarounds, but the idea is to not hide the ability to go past 100. I don't think users know they can go over 100, and in this particular module I think it's especially useful.

@kofa73
Copy link
Contributor

kofa73 commented Jan 23, 2025

Couldn't the function be tweaked instead, so instead of approaching 1 asymptotically, one could force it to actually reach it at a given level? I understand that making it converge to 1.5 instead of 1 achieves that, but if feel that is 'backwards': if the input changes (e.g. extra exposure is added, contrast is increased, the skew is adjusted), we could end up with values in the display-referred part > 1 -- and the role of the tone mapper is exactly to map from an unbounded range to one with well-defined bounds. > 1 is OK for HDR output, but not for most current formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants