Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use a particular branch of the SDK for QA testing purposes #3092

Open
1 of 2 tasks
cazala opened this issue Apr 29, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@cazala
Copy link
Member

cazala commented Apr 29, 2024

🎉 Description

Add a query param to load the SDK from a specific branch/PR so QA can test the branch in the context of the Builder, which allows them to test more use cases and catch integration issues earlier.

  • 🐛 This is a bug report.
  • 📈 This is a feature request.

📝 Details

The @dcl/inspector is a static webapp served from the Builder's own assets, but when a PR is created in the SDK repo, a preview is always deployed to cloudflare pages. So technically we could pass a query param, like ?sdk-branch=fix/something telling the Builder to load the assets of the editor from a particular PR, get the CF pages url, and use that instead of the local url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant