Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor try_parse in table_properties/deserialize.rs #682

Open
zachschuermann opened this issue Feb 6, 2025 · 0 comments
Open

refactor try_parse in table_properties/deserialize.rs #682

zachschuermann opened this issue Feb 6, 2025 · 0 comments

Comments

@zachschuermann
Copy link
Collaborator

bad pattern for each table property we do Some(parse(v)?). if someone does just parse(v) instead this is correct to the compiler but has different behavior: we don't return none in those cases.

"delta.appendOnly" => props.append_only = Some(parse_bool(v)?),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant