Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCS name to project lock resource name to avoid naming conflicts #1678

Open
motatoes opened this issue Aug 24, 2024 · 0 comments
Open

Add VCS name to project lock resource name to avoid naming conflicts #1678

motatoes opened this issue Aug 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@motatoes
Copy link
Contributor

Currently our lock resource names (PR locks) are of the format diggerhq/demo-opentofu#dev, so its repo org, repo name and project name. However as we expand to multiple CI systems this will cause conflicts of names, therefore I propose to add the vCS name to the resource name to avoid this naming conflicts:

github#diggerhq/demo-opentofu#dev
gitlab#diggerdev/demo-opentofu#prod

In that way we guarantee uniqueness in digger cloud

This is more a concern for the cloud offering rather than the self-hosted instances or backendless modes, however applying globally will safeguard against any future conflicts.

If we change the name then existing locks will be invalidated. In order to make it a graceful move we can only apply this change to the digger_locks database table (other backend cloud-based locks such as dynamoDB will remain the same). This then makes it a graceful change and therefore no lock invalidation will occur

@motatoes motatoes added the enhancement New feature or request label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant