Zipdirectory lacks Comment and Password properties

[andywu188]

Summary

I need to specify the ZIP password when using Zipdirectory task, and the comment of ZIP,

src/Tasks/ZipDirectory.cs

Background and Motivation

When I use Zipdirectory Task, I need to set annotations for the ZIP package, but Zipdirectory does not provide such parameters

<ZipDirectory SourceDirectory="$(OutputPath)" DestinationFile="$(MSBuildProjectDirectory)\output.zip" />

Proposed Feature

<ZipDirectory SourceDirectory="$(OutputPath)" DestinationFile="$(MSBuildProjectDirectory)\output.zip" Comment="my zip" Password="my pwd" />

Alternative Designs

Reference Example:
https://github.com/loresoft/msbuildtasks/blob/De6d85c8feb4bf9a71D7CABF76F76BDC80/msbuild.community.task.cs# L135

    /// <summary>
    /// Gets or sets the comment.
    /// </summary>
    /// <value>The comment.</value>
    public string Comment { get; set; }

    /// <summary>
    /// Gets or sets the password.
    /// </summary>
    /// <value>The password.</value>
    public string Password { get; set; }

[KalleOlaviNiemitalo]

Do any other tasks have Password parameters? It would be good if MSBuild didn't write the values of such parameters to its logs, but I don't think MSBuild currently knows which parameters contain secrets. Related: #8520 (comment)

[andywu188]

是否有任何其他任务具有 Password 参数？如果 MSBuild 没有将此类参数的值写入其日志，那就太好了，但我认为 MSBuild 目前不知道哪些参数包含机密。相关新闻： #8520 （评论）

The following task has a password parameter. At present, there is no personnel maintenance in this project, and there are some bugs in the project, which cannot be repaired.

https://github.com/loresoft/msbuildtasks/blob/de6d85c8feb4bf9a71d7ca9e145cabf76f4bdc80/Source/MSBuild.Community.Tasks/Zip.cs#L151

[rainersigwald]

I don't think we expect the built-in ZipDirectory to support all possible features of Zip, and since there are secrets involved here I would prefer not to expose it in MSBuild. Since it doesn't look like the .NET Zip API includes password support I don't think we expect to do this.