Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to use a file list with trusted-signing returns error #768

Open
nicktf01 opened this issue Oct 2, 2024 · 2 comments
Open

Attempting to use a file list with trusted-signing returns error #768

nicktf01 opened this issue Oct 2, 2024 · 2 comments
Labels
Priority:3 Work that is nice to have

Comments

@nicktf01
Copy link

nicktf01 commented Oct 2, 2024

I'm trying to use a filelist to skip when signing the contents of a directory using trusted-signing

Repro steps

The following command is being executed from the directory containing the target files for signing. If I remove "-fl filelist.txt" and substitute "*.exe" the command completes successfully

"{path}\sign.exe code trusted-signing -tse "{path to endpoint}" -tsa "{trusted-Signing-Account}" -tscp {Cert Profile} -b {WorkingDir} -fl filelist.txt -v debug

Content of filelist.txt

**/*.exe
!**/Don'tSignMe.exe

Expected behavior
To sign all *.exe files in current working directory with one exclusion

Actual behavior
Program returns "Required argument missing for command: 'trusted-signing'."

If I add a wildcard after the filelist as in the example below, all files will get signed and the filelist will be ignored.

"{path}\sign.exe code trusted-signing -tse "{path to endpoint}" -tsa "{trusted-Signing-Account}" -tscp {Cert Profile} -b {WorkingDir} -fl filelist.txt * -v debug

Additional context
Version 0.9.1-beta.24469.1

@kauppine
Copy link

kauppine commented Oct 3, 2024

I also stumbled upon this previously and after looking around in the code, I noticed that the file-list only works with containers (zip, clickonce etc.). As a workaround, you could zip your directory and call
"{path}\sign.exe code trusted-signing -tse "{path to endpoint}" -tsa "{trusted-Signing-Account}" -tscp {Cert Profile} -b {WorkingDir} -fl filelist.txt -v debug *.zip

It would be nice if the file-list option worked with plain wildcard as a files to sign argument,

@nicktf01
Copy link
Author

nicktf01 commented Oct 3, 2024

Thank you! Yes, I poked around and that was the conclusion I came to as well, but I thought I must be missing something. Seconded for having this work on unzipped files.

@dtivel dtivel added the Priority:3 Work that is nice to have label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

3 participants