Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowsBase tests seems to fail on CI randomly with x64 Debug/Release #10250

Open
h3xds1nz opened this issue Jan 9, 2025 · 2 comments · May be fixed by #10304
Open

WindowsBase tests seems to fail on CI randomly with x64 Debug/Release #10250

h3xds1nz opened this issue Jan 9, 2025 · 2 comments · May be fixed by #10304
Assignees
@ThomasGoulet73
Labels
🚧 work in progress Test or Test Infrastructure Improvements of test source code

Comments

@h3xds1nz
Copy link
Contributor

h3xds1nz commented Jan 9, 2025

The issue

This is 4th time out of like 15 CI builds this week that the WindowsBase tests have randomly failed on CI in x64 Release configuration only.

It seems like the two tests we have at the moment (Size, SplashScreen) itself do not fail though, they appear to pass - https://dev.azure.com/dnceng-public/public/_build/results?buildId=912047&view=ms.vss-test-web.build-test-results-tab

Other information

It is not reproducible for me locally when I'm building for x64 in release mode at all given numerous builds, so I wonder whether it has something to do with the CI builds in general or there's actually an issue with splash screen.

Might be worth looking into.
@siagupta0202 siagupta0202 added the Investigate Requires further investigation by the WPF team. label Jan 10, 2025
@h3xds1nz h3xds1nz changed the title WindowsBase tests seems to fail on CI randomly with x64 Release WindowsBase tests seems to fail on CI randomly with x64 Debug/Release Jan 15, 2025
@ThomasGoulet73
Copy link
Contributor

ThomasGoulet73 commented Jan 17, 2025 •
edited
Loading

I was able to reproduce locally, this is caused by the build not building the projects in the right order and the test projects sometimes being built before the native projects.

I have a fix ready that I'll send in a minute.

I'm assigning this issue to myself.

Thanks @h3xds1nz for opening this and FYI the reason you see the tests all passing was because the tests failed to start so it failed to detect the tests to run so it was like PresentationCore.Tests.dll in Release x64 had 0 tests and 0 tests either passing, failing or skipped. If you want to investigate issues like this in the future you can go to the artifacts tab and download the artifacts tab for the configuration that failed and check in the log file (There's one for each project).

@ThomasGoulet73 ThomasGoulet73 added Test or Test Infrastructure Improvements of test source code and removed Investigate Requires further investigation by the WPF team. labels Jan 17, 2025
@ThomasGoulet73 ThomasGoulet73 self-assigned this Jan 17, 2025
ThomasGoulet73 added a commit to ThomasGoulet73/wpf that referenced this issue Jan 17, 2025
@ThomasGoulet73
Fix flaky tests.
47039d3 
Fixes dotnet#10250
@ThomasGoulet73 ThomasGoulet73 linked a pull request Jan 17, 2025 that will close this issue
Open
@h3xds1nz
Copy link
Contributor Author

@ThomasGoulet73 Thanks Thomas for taking a look; great find.

And thanks for englightening me with the artifacts, I had no idea I can download them haha.

ThomasGoulet73 added a commit to ThomasGoulet73/wpf that referenced this issue Jan 18, 2025
@ThomasGoulet73
Fix flaky tests.
e540f17 
Fixes dotnet#10250
ThomasGoulet73 added a commit to ThomasGoulet73/wpf that referenced this issue Jan 18, 2025
@ThomasGoulet73
Fix flaky tests.
0ea5102 
Fixes dotnet#10250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasGoulet73 ThomasGoulet73

Labels
🚧 work in progress Test or Test Infrastructure Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky tests ThomasGoulet73/wpf
3 participants
@ThomasGoulet73 @h3xds1nz @siagupta0202