Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name or missing Countries #227

Closed
VisiGod opened this issue Jun 6, 2021 · 7 comments
Closed

Wrong name or missing Countries #227

VisiGod opened this issue Jun 6, 2021 · 7 comments
Assignees
Labels

Comments

@VisiGod
Copy link

VisiGod commented Jun 6, 2021

First let me thank you for all the work you've put into this and take this issue as an improvement

"Croatia (Hrvatska)" - Should be named only "Croatia"
"Netherlands The" - Should be named "Netherlands" or "The Netherlands"
"Korea North" - Should be named North Korea
"Korea South" - Should be named South Korea
"England", "Northern Ireland", "Scotland", "Wales" don't exist (they are countries inside the United Kingdom but are recognized as countries)

@dr5hn
Copy link
Owner

dr5hn commented Jun 7, 2021

@VisiGod You're most welcome. Thanks for reporting. 🎉

The first 4 points are clear, the last one is doubtful. I will take a look at it soon and let you know if any questions.

@dr5hn dr5hn self-assigned this Jun 7, 2021
@dr5hn dr5hn added the enhancement New feature or request label Jun 7, 2021
@VisiGod
Copy link
Author

VisiGod commented Jun 13, 2021

Regarding the last issue, sometimes we need to select a specific country inside UK and since they aren't available, it's a deal breaker for some uses.

@dr5hn
Copy link
Owner

dr5hn commented Jun 13, 2021

@VisiGod Currently "England", "Northern Ireland", "Scotland", "Wales" These are marked as a States. So you mean we need to mark them as a country instead of States?

@VisiGod
Copy link
Author

VisiGod commented Jul 4, 2021

@dr5hn I think they should be marked as countries and not states. California is a US state as West Midlands is a region of England.

All four are countries in my understanding:
England - https://en.wikipedia.org/wiki/England
Northern Ireland - https://en.wikipedia.org/wiki/Northern_Ireland
Scotland - https://en.wikipedia.org/wiki/Scotland
Wales - https://en.wikipedia.org/wiki/Wales

Or you may check https://en.wikipedia.org/wiki/Countries_of_the_United_Kingdom

Although some people refer to the UK as a country (not wrong), their constituent are also countries.

I would also like to know if it was possible to include former countries (like USSR, Yugoslavia, East and West Germany) since it could be of use when using the database to refer to old/former countries

@joaorb64
Copy link
Contributor

The first 4 I think would be very helpful changes. In all data I work on using this repo's data, these come up as special cases because of how their names are configured; while the data on the other side is always configured with the suggested names.

@dr5hn
Copy link
Owner

dr5hn commented Jul 25, 2021

@VisiGod //cc @joaorb64 I've fixed the first 4 naming issues.

The Remaining needs more brainstorming. Will tackle them later.

@dr5hn dr5hn mentioned this issue Sep 7, 2021
@dr5hn dr5hn added UK and removed enhancement New feature or request labels Sep 7, 2021
@dr5hn dr5hn pinned this issue Sep 7, 2021
@dr5hn dr5hn added the Hacktoberfest Hacktoberfest 2021 label Oct 5, 2021
@dr5hn dr5hn removed the Hacktoberfest Hacktoberfest 2021 label Nov 8, 2021
@dr5hn dr5hn mentioned this issue May 28, 2022
Closed
@dr5hn dr5hn unpinned this issue Jun 17, 2022
@dr5hn
Copy link
Owner

dr5hn commented Sep 5, 2024

Duplicate of #290

@dr5hn dr5hn marked this as a duplicate of #290 Sep 5, 2024
@dr5hn dr5hn closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants