Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy with currencies for some countries #903

Open
Vrajs16 opened this issue Oct 17, 2024 · 1 comment · May be fixed by #909
Open

Discrepancy with currencies for some countries #903

Vrajs16 opened this issue Oct 17, 2024 · 1 comment · May be fixed by #909
Labels
bug Something isn't working

Comments

@Vrajs16
Copy link

Vrajs16 commented Oct 17, 2024

I was trying to create a currency table and found some duplicates

  1. For the country "Congo", the currency_symbol should be "FCFA".
  2. Countries with "MAD" currency code should have currency_name "Moroccan Dirham" and currency_symbol "MAD"
  3. Countries with "XCD" currency code should have currency_name "Eastern Caribbean dollar"
  4. Countries with "USD" currency code should have currency_name "United States dollar"
  5. Countries with "NZD" currency code should have currency_name "New Zealand dollar"
  6. Countries with "NOK" currency code should have currency_name "Norwegian krone"

These are my findings and hope when someone has time can fix this on this repo. Thanks

Copy link

dosubot bot commented Oct 17, 2024

Hey @Vrajs16! 👋 I'm here to help you with any bugs, questions, or contributions you have on this repo. Let's squash those bugs together!

I wasn't able to find any documented issues or discrepancies regarding currency data in the repository, so it's possible that these discrepancies haven't been officially noted yet. If you have identified these issues, it might be helpful to update the relevant JSON or XML files where currency details are stored, such as currency_symbols.json or xml/countries.xml [1][2].

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the bug Something isn't working label Oct 17, 2024
@mtsfer mtsfer linked a pull request Oct 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Vrajs16 and others