Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary comtrade files coverage + StatusChannels #12

Open
TurnOfACard opened this issue Apr 28, 2022 · 2 comments
Open

Binary comtrade files coverage + StatusChannels #12

TurnOfACard opened this issue Apr 28, 2022 · 2 comments
Labels
testing Relates to testing coverage, infrastructure etc.

Comments

@TurnOfACard
Copy link

StatusChannels with values other than zero are not covered in the test files

@drewsilcock
Copy link
Owner

Thanks for raising this issue.

If you mean there aren't any status channels where the "y" (a.k.a. the "steady state value") is 1 instead of 0, you're absolutely right. It's not really feasible to create test COMTRADE files with every possible characteristic which is why I'd like to get some proper unit tests in there, but that requires some refactoring so that unit testing is possible in the first place. In the meantime I could just change one of the test files to put a 1 instead of a 0 in the cfg - you're also welcome to do a PR if you want.

@drewsilcock drewsilcock added the testing Relates to testing coverage, infrastructure etc. label Apr 29, 2022
@TurnOfACard
Copy link
Author

Thanks for raising this issue.

If you mean there aren't any status channels where the "y" (a.k.a. the "steady state value") is 1 instead of 0, you're absolutely right. It's not really feasible to create test COMTRADE files with every possible characteristic which is why I'd like to get some proper unit tests in there, but that requires some refactoring so that unit testing is possible in the first place. In the meantime I could just change one of the test files to put a 1 instead of a 0 in the cfg - you're also welcome to do a PR if you want.

I'll see what I can do. The reason I mention it was when I refactored status channels I saw that a change I made wasn't caught

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to testing coverage, infrastructure etc.
Projects
None yet
Development

No branches or pull requests

2 participants