You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you mean there aren't any status channels where the "y" (a.k.a. the "steady state value") is 1 instead of 0, you're absolutely right. It's not really feasible to create test COMTRADE files with every possible characteristic which is why I'd like to get some proper unit tests in there, but that requires some refactoring so that unit testing is possible in the first place. In the meantime I could just change one of the test files to put a 1 instead of a 0 in the cfg - you're also welcome to do a PR if you want.
If you mean there aren't any status channels where the "y" (a.k.a. the "steady state value") is 1 instead of 0, you're absolutely right. It's not really feasible to create test COMTRADE files with every possible characteristic which is why I'd like to get some proper unit tests in there, but that requires some refactoring so that unit testing is possible in the first place. In the meantime I could just change one of the test files to put a 1 instead of a 0 in the cfg - you're also welcome to do a PR if you want.
I'll see what I can do. The reason I mention it was when I refactored status channels I saw that a change I made wasn't caught
StatusChannels with values other than zero are not covered in the test files
The text was updated successfully, but these errors were encountered: