Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image thumbnails instead of rotating previews in the objects menu. #268

Open
drwhut opened this issue Apr 7, 2023 · 0 comments
Open
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Milestone

Comments

@drwhut
Copy link
Owner

drwhut commented Apr 7, 2023

Is your feature request related to a problem? Please describe.
The rotating 3D objects in the objects menu have been the source of quite a few issues due to the way threading works in the game. After having conversations with other Godot developers with regards to these issues, I've come to the conclusion that while the way I've implemented threading in Tabletop Club is flawed, it is also doomed to fail because of the fact that handling resources in multiple threads in any way is not safe in Godot. Therefore, in order to be thread-safe, the objects menu needs to at the very least use different resources to those used within the room.

Describe the solution you'd like
Use static, 2D thumbnails instead of dynamic, 3D ones to represent objects in the objects menu. They can be created during the import process and stored on the disk for later use. If the thumbnails are sufficiently compressed, then they can be kept in memory as to avoid having to load them in another thread altogether.

Describe alternatives you've considered
Keeping the current system - but as described above, it is fundamentally flawed. We could potentially duplicate the imported resources and dedicate one set to being shown in the objects menu, but this would take up a lot of disk space.

Additional context
This would end up fixing #216, #265 (only in the objects menu), and #267.

@drwhut drwhut added ui Related to the UI assets Related to assets or asset packs tweak Tweak an existing feature labels Apr 7, 2023
@drwhut drwhut added this to the v0.2.0 milestone Apr 7, 2023
drwhut added a commit that referenced this issue Sep 10, 2024
Now there's these cool things called folders! It's a totally new
invention, I think it'll do really well with those tiktok kids.

The way in which assets are displayed can also be adjusted now, with
both the button type and scale being variable.

This is primarily to fix #268, as the 3D previews were causing
random crashes in v0.1.x when going through the pages.

This also fixes #299, as tooltips now only show descriptions. I plan
to add a right-click option to show the full details of an asset.

This commit also contributes to #252, since tokens are now shown in
the UI as "Tiles / Tokens". The ability for tokens to be placed in
player's hands has not been implemented yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Projects
None yet
Development

No branches or pull requests

1 participant