You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The rotating 3D objects in the objects menu have been the source of quite a few issues due to the way threading works in the game. After having conversations with other Godot developers with regards to these issues, I've come to the conclusion that while the way I've implemented threading in Tabletop Club is flawed, it is also doomed to fail because of the fact that handling resources in multiple threads in any way is not safe in Godot. Therefore, in order to be thread-safe, the objects menu needs to at the very least use different resources to those used within the room.
Describe the solution you'd like
Use static, 2D thumbnails instead of dynamic, 3D ones to represent objects in the objects menu. They can be created during the import process and stored on the disk for later use. If the thumbnails are sufficiently compressed, then they can be kept in memory as to avoid having to load them in another thread altogether.
Describe alternatives you've considered
Keeping the current system - but as described above, it is fundamentally flawed. We could potentially duplicate the imported resources and dedicate one set to being shown in the objects menu, but this would take up a lot of disk space.
Additional context
This would end up fixing #216, #265 (only in the objects menu), and #267.
The text was updated successfully, but these errors were encountered:
Now there's these cool things called folders! It's a totally new
invention, I think it'll do really well with those tiktok kids.
The way in which assets are displayed can also be adjusted now, with
both the button type and scale being variable.
This is primarily to fix#268, as the 3D previews were causing
random crashes in v0.1.x when going through the pages.
This also fixes#299, as tooltips now only show descriptions. I plan
to add a right-click option to show the full details of an asset.
This commit also contributes to #252, since tokens are now shown in
the UI as "Tiles / Tokens". The ability for tokens to be placed in
player's hands has not been implemented yet.
Is your feature request related to a problem? Please describe.
The rotating 3D objects in the objects menu have been the source of quite a few issues due to the way threading works in the game. After having conversations with other Godot developers with regards to these issues, I've come to the conclusion that while the way I've implemented threading in Tabletop Club is flawed, it is also doomed to fail because of the fact that handling resources in multiple threads in any way is not safe in Godot. Therefore, in order to be thread-safe, the objects menu needs to at the very least use different resources to those used within the room.
Describe the solution you'd like
Use static, 2D thumbnails instead of dynamic, 3D ones to represent objects in the objects menu. They can be created during the import process and stored on the disk for later use. If the thumbnails are sufficiently compressed, then they can be kept in memory as to avoid having to load them in another thread altogether.
Describe alternatives you've considered
Keeping the current system - but as described above, it is fundamentally flawed. We could potentially duplicate the imported resources and dedicate one set to being shown in the objects menu, but this would take up a lot of disk space.
Additional context
This would end up fixing #216, #265 (only in the objects menu), and #267.
The text was updated successfully, but these errors were encountered: