Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to stop pre-made games from overwriting the current skybox. #304

Open
GrimPixel opened this issue Aug 26, 2023 · 2 comments
Open
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Milestone

Comments

@GrimPixel
Copy link

GrimPixel commented Aug 26, 2023

Is your feature request related to a problem? Please describe.
If players want to start a game, they don't necessarily want to change the 360-degree background image. Maybe also the table.

Describe the solution you'd like
The 360-degree background is not stored for “Games.”

@drwhut
Copy link
Owner

drwhut commented Aug 28, 2023

Apologies for the late reply!

I could see this going both ways, to be honest. I can imagine some situations as you described where players don't necessarily want to use the skybox that was in use at the time of the save file being created, but on the other hand, I could also see some skyboxes fitting really well with the theme of certain games (e.g. a Werewolf game having a night-time/town skybox).

One thing I was considering adding in the v0.2.0 update is an additional pop-up dialog when the player is about to load a pre-made game, giving extra details about the game and more room for the description text box so that creators can put more of the rules or setup instructions in the config file. As part of this new dialog box, there could be a checkbox that, if enabled, would set the skybox to the one in the save file. That would give players the ability to choose whether they want to keep the current skybox or not, and it could be expanded upon later to include additional options or tweaks.

Another potential solution is to add a property to the config file for skyboxes, e.g. force_skybox, or something along those lines, that would tell the game if it should force the current skybox to be overwritten or not.

Either way, I think it makes sense to give players or creators the choice here since I can see both cases being wanted just as much as each other.

@drwhut drwhut added ui Related to the UI assets Related to assets or asset packs tweak Tweak an existing feature labels Aug 28, 2023
@drwhut drwhut added this to the v0.2.0 milestone Aug 28, 2023
@drwhut drwhut changed the title Remove room (background) information for “Games” Add a way to stop pre-made games from overwriting the current skybox. Aug 28, 2023
@GrimPixel
Copy link
Author

GrimPixel commented Aug 29, 2023

I would like to leave the choice of whether a game should change its background to players, and let the asset creator decide if the option is enabled by default. Considering the table, radios / megaphones, there could be more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Projects
None yet
Development

No branches or pull requests

2 participants