Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ESM is currently blocked #6038

Open
usu opened this issue Sep 29, 2024 · 1 comment
Open

Upgrade to ESM is currently blocked #6038

usu opened this issue Sep 29, 2024 · 1 comment
Assignees
@BacLuc
Milestone
Updates and impro...

Comments

@usu
Copy link
Member

usu commented Sep 29, 2024

@usu usu mentioned this issue Sep 29, 2024
Merged
@usu
Copy link
Member Author

usu commented Sep 29, 2024

eslint-plugin-local rules might not be necessary with introduction of eslint flat config. There seems to be possibilities to load custom rules directly from the config:

https://eslint.org/blog/2022/08/new-config-system-part-2/#from---rulesdir-to-runtime-plugins
https://eslint.org/docs/latest/extend/custom-rule-tutorial

This was referenced Sep 29, 2024
Closed
Closed
Closed
Closed
Closed
@BacLuc BacLuc added this to the Improvements (v3.2) milestone Dec 3, 2024
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 21, 2024
@BacLuc
frontend: set type to module in package.json
ab85dfd 
This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038
@BacLuc BacLuc mentioned this issue Dec 21, 2024
Merged
1 task
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 21, 2024
@BacLuc
pdf: switch to module
1999c81 
And might help with
- ecamp#6038
@BacLuc BacLuc mentioned this issue Dec 21, 2024
Closed
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 21, 2024
@BacLuc
frontend/pdf/print: set type to module in package.json
56ef60d 
And switch to esm syntax for the matchingTranslationKeys eslint plugin.

Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.

This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 21, 2024
@BacLuc
frontend/pdf/print: set type to module in package.json
e7b9659 
And switch to esm syntax for the matchingTranslationKeys eslint plugin.

Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.

This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 21, 2024
@BacLuc
frontend/pdf/print: set type to module in package.json
e932b28 
And switch to esm syntax for the matchingTranslationKeys eslint plugin.

Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.

This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 22, 2024
@BacLuc
frontend/pdf/print: set type to module in package.json
30f8c7d 
And switch to esm syntax for the matchingTranslationKeys eslint plugin.

Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.

jest-serializer-vue-tjw loads the vue config with require,
and seems to expect a commonjs module.
We switched to a esm module, and now the structure is not
pluginOptions.jestSerializer,
but
default.pluginOptions.jestSerializer
-> with the added export we can support vue itself and jest-serializer-vue-tjw.

This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038

Fix checked in dist files in pdf/dist/
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Dec 22, 2024
@BacLuc
frontend/pdf/print: set type to module in package.json
b6142f4 
And switch to esm syntax for the matchingTranslationKeys eslint plugin.

Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.

jest-serializer-vue-tjw loads the vue config with require,
and seems to expect a commonjs module.
We switched to a esm module, and now the structure is not
pluginOptions.jestSerializer,
but
default.pluginOptions.jestSerializer
-> with the added export we can support vue itself and jest-serializer-vue-tjw.

This might enable us to update vite-plugin-comlink
- ecamp#6220
And might help with
- ecamp#6038

Fix checked in dist files in pdf/dist/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BacLuc BacLuc

Labels
None yet
Projects
None yet
Milestone
Updates and improvements (v3.2)
Development

No branches or pull requests
2 participants
@usu @BacLuc