Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option to disable smoothing #298

Open
andrewdbate opened this issue Jan 20, 2022 · 4 comments
Open

Feature request: Add option to disable smoothing #298

andrewdbate opened this issue Jan 20, 2022 · 4 comments

Comments

@andrewdbate
Copy link
Contributor

Please add an option to disable smoothing. This is something which is supported by Gnome System Monitor.

Here is an example CPU plot from Gnome System Monitor (of a stacked chart):
smoothing-enabled
Here is how the plot can look with smoothing disabled:
smoothing-disabled

The option to disable smooth plots is within the Gnome System Monitor preferences dialog:
gnome-system-monitor-preferences

Here is another plot from Gnome System Monitor (not a stacked chart):
with-smoothing-not-stacked
And the same kind of plot with smoothing disabled:
without-smoothing-not-stacked

The rationale for this feature request: I find the CPU plots easier to read with the smooth lines disabled because having slightly less detail makes it easier to identify what is going on with only a quick glance.

@andrewdbate
Copy link
Contributor Author

Now that 0.13.0 has been released, I see that there is an option to enable/disable smooth lines on the CPU chart (however, this option currently requires Monitor to be restarted):

Screenshot from 2022-03-20 16 39 26

One small suggestion would be to change the wording from "Enable smooth lines for a CPU chart (needs restart)" to "Enable smooth lines on the CPU chart (requires restart)". I think that might be technically more correct because there is only one CPU chart, and also sounds slightly better to me as a native speaker.

I guess for this feature to be fully completed it would be good to be able to enable/disable smooth lines without a restart.

@andrewdbate
Copy link
Contributor Author

Here is a video of how Gnome System Monitor handles the turning on/off of smooth lines (43 seconds):

gnome_monitor_smooth_turn_on_off.mp4

As you can see, in Gnome System Monitor, when you toggle on or off "Draw CPU chart as smooth graph", the chart is cleared and it redraws from the beginning.

It would be slightly more elegant to draw either with or without smooth lines starting from the next clock tick (and that way the user can more easily see the difference between smooth and not smooth) instead of clearing the graph and starting again.

@andrewdbate
Copy link
Contributor Author

Thinking again about the wording on which I commented above: It would be even more concise to say "Draw smooth lines on CPU chart (requires restart)".

This would take up less horizontal width.

@stsdc
Copy link
Member

stsdc commented Mar 26, 2022

Yes, I'll try to make it restartless. However I'll wait until a new version of live-chart will be released. Hope it will natively support stacked charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants