Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Submodules #384

Open
danirabbit opened this issue Oct 9, 2024 · 2 comments
Open

Remove Submodules #384

danirabbit opened this issue Oct 9, 2024 · 2 comments

Comments

@danirabbit
Copy link
Member

What Happened?

Right now there are dependencies that are pulled in with submodules, these should be properly packaged dependencies instead

Steps to Reproduce

https://github.com/elementary/monitor/blob/dev/.gitmodules

Expected Behavior

It looks like maybe Monitor pulls in the elementary stylesheet for the color palette? These variables are available in Granite >= 7 when you Granite.init (), so this would be fixed by a GTK4 port

LiveChart should be packaged separately in the elementary PPA so it can be depended on normally in packaging

OS Version

8.x (Early Access)

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@stsdc
Copy link
Member

stsdc commented Oct 9, 2024

Regarding the live-chart, how to add this external dependency into the PPA?

@danirabbit
Copy link
Member Author

@stsdc That's something someone with LP access has to do, so very likely a task for me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants