Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for BfsNodeVisitor is inaccurate #33

Open
DavidDTA opened this issue Jan 18, 2025 · 0 comments
Open

Documentation for BfsNodeVisitor is inaccurate #33

DavidDTA opened this issue Jan 18, 2025 · 0 comments

Comments

@DavidDTA
Copy link

There are two inaccuracies, both of which are demonstrated by this Ellie

  • The documentation says

    it holds always that length path == distance - 1

    but actually length path == distance + 1

  • The documentation says

    the path of contexts from the root to the current node is passed instead of just the current node's context

    but the path is actually passed in the reverse order, from the current node to the root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant